About Duffbert...

Duffbert's Random Musings is a blog where I talk about whatever happens to be running through my head at any given moment... I'm Thomas Duff, and you can find out more about me here...

Email Me!

Search This Site!

Custom Search

I'm published!

Co-author of the book IBM Lotus Sametime 8 Essentials: A User's Guide
SametimeBookCoverImage.jpg

Purchase on Amazon

Co-author of the book IBM Sametime 8.5.2 Administration Guide
SametimeAdminBookCoverImage.jpg

Purchase on Amazon

MiscLinks

Visitor Count...



View My Stats

« Boy, I haven't had that bad a day as a developer in a LONG time... | Main| Admins... how they view themselves... »

It's humbling to put your code out there for others to see (subtitled: Just another day of frustration...)

Category Software Development

Ok...  so we have day 2 of my application that refuses to behave.  I stripped plenty of stuff out that, on review, could have been a bottleneck.  And twice we fired it up, only to peg the server at 100% again.  Granted, it took longer to do so, but it was still not good enough to leave in production.

Phigment offered via Twitter to take a look at the code for a second set of eyes, and I just got off the call with him.  Talking about feeling STOOOOOOOOPID!  He quite accurately pointed out a number of potential troublespots (after I thought I had already gotten rid of them all), along with suggestions for change.  This, coupled with something I brainstormed out with a user this afternoon, may well make this an app that will run like it *should* be running.

First off, my thanks to everyone who has chimed in and helped.  It's great to be part of such a strong community of Notes-aholics who care and work with each other without expecting much in return, knowing that they too will need help some day.

And to another point that hit me even harder...  It doesn't matter how long you've been coding and developing...  You have bad habits.  Having Phig dig into my code and ask "why" was rather embarrassing.  I know I'm better than some of the things he found, but you're going fast trying to meet deadlines.  You know you'll go back and clean up the repetitive code.  And you never do.  But it doesn't matter, as no one else will ever see it.  Until you have to ask for help.  I feel like I went from a 10 year developer to a 1 year developer repeated 10 times.  

I need to dwell on this idea of seeking out code reviews from others you respect...  For one, I don't want to repeat this week ever again, and two, I don't want to be that red-faced again.  I've definitely been given my much-needed reality check.

Comments

Gravatar Image1 - Very brave of you to expose your code and blog about it. I commend you.
I had a day yesterday that I knew from the start was going to go bad. SWMBO blasted me first thing AM before my eyes were open and it went downhill from there.
Here's to a better day!

Gravatar Image2 - It's all good! The problem with cut and paste is cut and paste. It makes it way to easy to put less than efficient code all over the place. It is one of the main reasons I started putting applications onto OpenNTF. It's not that I am an ASW, well not a complete one, but rather that I wanted other people to see what I had written and possibly tell me how to do it better.

Remember, you never learn as much from your successes as you do from your failures.

Gravatar Image3 - On a similar topic, I got a call/email from someone in Virginia that wants to build a Notesapp with a sesasoned developer so they can understand how to do it.
So far no one has replied, goignto blog it and see if anyone is interested in helping this guy out.

Gravatar Image4 - Tom...I think a lot of us would benefit from this kind of help. Code reviews are great. Sometimes it is even better to work in a team situation. But don't be too hard on yourself. I learned a long time ago that I would never be close to the best coder out there. Instead, I focused on getting apps that add business value out the door quickly. Sometimes if this means sacrificing perfect code...so be it. (Usually) Notes is pretty forgiving and allows us to craft solutions much faster than anything else out there. That's just my opinion, but it's what makes Notes so great.

That said...remember that even with crappy code, you should have a nice interface! Emoticon

Post A Comment

:-D:-o:-p:-x:-(:-):-\:angry::cool::cry::emb::grin::huh::laugh::lips::rolleyes:;-)

Want to support this blog or just say thanks?

When you shop Amazon, start your shopping experience here.

When you do that, all your purchases during that session earn me an affiliate commission via the Amazon Affiliate program. You don't have to buy the book I linked you to (although I wouldn't complain!). Simply use that as your starting point.

Thanks!

Thomas "Duffbert" Duff

Ads of Relevance...